fix(attention_dispatch): use correct attr names for FLASH_VARLEN_HUB …#14015
Open
Vitaliy-Pikalo wants to merge 1 commit into
Open
fix(attention_dispatch): use correct attr names for FLASH_VARLEN_HUB …#14015Vitaliy-Pikalo wants to merge 1 commit into
Vitaliy-Pikalo wants to merge 1 commit into
Conversation
…kernels-community/flash-attn2 The `kernels-community/flash-attn2` hub kernel exposes: - `flash_attn_interface._flash_attn_varlen_forward` - `flash_attn_interface._flash_attn_varlen_backward` But `_HUB_KERNELS_REGISTRY[FLASH_VARLEN_HUB]` was referencing: - `flash_attn_interface._wrapped_flash_attn_varlen_forward` - `flash_attn_interface._wrapped_flash_attn_varlen_backward` Those `_wrapped_*` attributes do not exist in the hub kernel, causing `_flash_attention_varlen_hub` to fail with an AttributeError when trying to resolve them. Contrast with `FLASH_HUB` (non-varlen flash-attn2), which correctly uses `_wrapped_flash_attn_forward/backward` — the standard flash-attn2 library does expose those names, but the hub varlen kernel uses the unwrapped form. Also updates the RuntimeError message in `_flash_attention_varlen_hub` to match the corrected attribute names. Fixes huggingface#14012.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
kernels-community/flash-attn2hub kernel exposes:flash_attn_interface._flash_attn_varlen_forwardflash_attn_interface._flash_attn_varlen_backwardBut
_HUB_KERNELS_REGISTRY[FLASH_VARLEN_HUB]was referencing the non-existent:flash_attn_interface._wrapped_flash_attn_varlen_forwardflash_attn_interface._wrapped_flash_attn_varlen_backwardThose
_wrapped_*attributes don't exist in the hub varlen kernel, so_flash_attention_varlen_hubwould fail with anAttributeErrorwhen trying to resolve them at runtime.For reference,
FLASH_HUB(non-varlen flash-attn2) correctly uses_wrapped_flash_attn_forward/backward— the standard flash-attn2 library does expose those names. But the hub varlen kernel uses the unwrapped form (no_wrapped_prefix), consistent with how_FLASH_3_HUB(flash-attn3) uses_flash_attn_forward/backward.This PR also updates the
RuntimeErrormessage in_flash_attention_varlen_hub(both forward and backward ops) to match the corrected attribute names.Fixes #14012.