[ci] xfail more incorrect transformer imports. #12455
Open
+2
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg845
reviewed
Oct 14, 2025
| assert deprecated_warning_msg in str(cap_logger), "Deprecation warning not found in logs" | ||
|
|
||
| @pytest.mark.xfail(condition=is_transformers_version(">", "4.56.2"), reason="Some import error", strict=True) | ||
| def test_download_safetensors_only_variant_exists_for_model(self): |
There was a problem hiding this comment.
Perhaps I am missing something, but it appears that this test (and test_download_safetensors_variant_does_not_exist_for_model below) are still marked as failed rather than xfailed in the CI:
FAILED tests/pipelines/test_pipelines.py::DownloadTests::test_download_safetensors_only_variant_exists_for_model
FAILED tests/pipelines/test_pipelines.py::DownloadTests::test_download_safetensors_variant_does_not_exist_for_model
Is this expected?
There was a problem hiding this comment.
Yeah this is not expected and seeing for the first time. Let me check.
dg845
reviewed
Oct 14, 2025
There was a problem hiding this comment.
It looks like the following tests are still failing on the CI:
tests/pipelines/test_pipelines.py::DownloadTests::test_download_bin_only_variant_exists_for_modeltests/pipelines/test_pipelines.py::DownloadTests::test_download_bin_variant_does_not_exist_for_model
These tests also previously failed on the (unrelated) PR #12463, see #12463 (comment). So probably these tests should also be xfail-ed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Hopefully, the last ones.