[tests] Changes to the torch.compile() CI and tests#11508
Merged
Conversation
Member
Author
|
@DN6 a gentle ping. |
DN6
approved these changes
May 26, 2025
DN6
left a comment
DN6
left a comment
Collaborator
There was a problem hiding this comment.
Looks good 👍🏽 Thanks. Minor comments.
| expected_set = {"HunyuanVideoTransformer3DModel"} | ||
| super().test_gradient_checkpointing_is_applied(expected_set=expected_set) | ||
|
|
||
| @require_torch_gpu |
Collaborator
There was a problem hiding this comment.
Would make sense to add these decorators to the top of the Mixin no?
Member
Author
There was a problem hiding this comment.
These decorators are present in the mixin:
diffusers/tests/models/test_modeling_common.py
Lines 1762 to 1765 in b5c2050
|
|
||
| container: | ||
| image: diffusers/diffusers-pytorch-compile-cuda | ||
| image: diffusers/diffusers-pytorch-cuda |
Collaborator
There was a problem hiding this comment.
Small nit. We can remove the -k "compile" in the test runner step.
Member
Author
|
Thanks for the reviews, @DN6! Hope to make our compile CI better and better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Regarding the final point, I think we already test torch.compile() support for popular models and doing it at the pipeline-level makes little sense to me. But no strong opinions.