Skip to content

Improve scroll buttons handling #1926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve scroll buttons handling #1926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b15de16
install runed
TGlide Oct 3, 2025
7d43fec
improve scroll buttons handling
TGlide Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 36 additions & 13 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@
"pino": "^9.0.0",
"pino-pretty": "^11.0.0",
"postcss": "^8.4.31",
"runed": "^0.34.0",
"satori": "^0.10.11",
"satori-html": "^0.3.2",
"sharp": "^0.33.4",
Expand Down
29 changes: 3 additions & 26 deletions src/lib/components/ScrollToBottomBtn.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<script lang="ts">
import { fade } from "svelte/transition";
import IconChevron from "./icons/IconChevron.svelte";
import { ScrollState } from "runed";

interface Props {
scrollNode: HTMLElement;
Expand All @@ -9,32 +10,8 @@

let { scrollNode, class: className = "" }: Props = $props();

let visible = $state(false);
let observer: ResizeObserver | null = $state(null);

function updateVisibility() {
if (!scrollNode) return;
visible =
Math.ceil(scrollNode.scrollTop) + 200 < scrollNode.scrollHeight - scrollNode.clientHeight;
}

function destroy() {
observer?.disconnect();
scrollNode?.removeEventListener("scroll", updateVisibility);
}
const cleanup = $effect.root(() => {
$effect(() => {
if (scrollNode) {
if (window.ResizeObserver) {
observer = new ResizeObserver(() => updateVisibility());
observer.observe(scrollNode);
cleanup();
}
scrollNode?.addEventListener("scroll", updateVisibility);
}
});
return () => destroy();
});
const scrollState = new ScrollState({ element: () => scrollNode, offset: { bottom: 200 } });
const visible = $derived(!scrollState.arrived.bottom);
</script>

{#if visible}
Expand Down
36 changes: 3 additions & 33 deletions src/lib/components/ScrollToPreviousBtn.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,17 @@
<script lang="ts">
import { ScrollState } from "runed";
import { fade } from "svelte/transition";
import { onDestroy, untrack } from "svelte";
import IconChevron from "./icons/IconChevron.svelte";

let visible = $state(false);
interface Props {
scrollNode: HTMLElement;
class?: string;
}

let { scrollNode, class: className = "" }: Props = $props();
let observer: ResizeObserver | null = $state(null);

function updateVisibility() {
if (!scrollNode) return;
visible =
Math.ceil(scrollNode.scrollTop) + 200 < scrollNode.scrollHeight - scrollNode.clientHeight &&
scrollNode.scrollTop > 200;
}
const scrollState = new ScrollState({ element: () => scrollNode, offset: { top: 100 } });
const visible = $derived(!scrollState.arrived.top);

function scrollToPrevious() {
if (!scrollNode) return;
Expand All @@ -40,30 +34,6 @@
previousMessage.scrollIntoView({ behavior: "smooth", block: "start" });
}
}

function destroy() {
observer?.disconnect();
scrollNode?.removeEventListener("scroll", updateVisibility);
}

onDestroy(destroy);

$effect(() => {
scrollNode &&
untrack(() => {
if (scrollNode) {
destroy();

if (window.ResizeObserver) {
observer = new ResizeObserver(() => {
updateVisibility();
});
observer.observe(scrollNode);
}
scrollNode.addEventListener("scroll", updateVisibility);
}
});
});
</script>

{#if visible}
Expand Down
Loading