Skip to content

Conversation

@Starmania
Copy link
Contributor

@Starmania Starmania commented Oct 18, 2025

Closes #95

Switch to fs.promise
Drop Rimraf
Drop electron-window-state types (already included in the main package)
Drop Node types (included by node itself)
Move CONTRIBUTING to it's own file
Adopt Node 20 module/resolution and bump target to ES2022 (CJS/ESM compat)

@CLAassistant
Copy link

CLAassistant commented Oct 18, 2025

CLA assistant check
All committers have signed the CLA.

@pimterry
Copy link
Member

Thanks @Starmania! This is definitely helpful. Happy to upgrade TS as well too, if it doesn't break anything, go for it 👍

@Starmania Starmania marked this pull request as draft October 20, 2025 20:49
@Starmania
Copy link
Contributor Author

I will write more changes and checks

@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedtypescript@​4.7.4 ⏵ 5.9.3100 +110090 -109990 +10
Updatedsemver@​7.5.4 ⏵ 7.7.3100 +1100100 +190100
Updatedelectron-store@​8.0.0 ⏵ 11.0.2100 +1100100 +1100 +20100

View full report

@Starmania Starmania changed the title Drop Rimraf Update and remove dependencies Oct 21, 2025
@Starmania Starmania marked this pull request as ready for review October 21, 2025 08:55
@pimterry pimterry merged commit a8c0c84 into httptoolkit:main Oct 22, 2025
10 checks passed
@pimterry
Copy link
Member

Nice work, thanks @Starmania! Merged 👍

As noted in your contributing docs, it was tricky building this due to the signing config, and that's why there were no tests on this CI either. I've just changed the build setup so that now builds do run (with signing disabled) and force pushed to enable that here, with a couple of related tweaks.

By the way, in case you're not aware, HTTP Toolkit Pro is free for all contributors to all https://github.com/httptoolkit repos. If that would be useful, just let me know your email (either here or by sending a message to opensource @ httptoolkit.com) and I'll set you up with an account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Discussion: Remove useless dependencies

3 participants