Add keyboard shortcut to enable the Jitter screensaver #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add keyboard shortcut for Jitter screensaver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer: I've never done a pull request before, so feel free to reject this for any reason.
After I opened #272, I took a look at the keyboard handler code. I found that the enable screensaver hotkey was hard coded to enable the pong screensaver. It looked like the keyboard handlers referred to the state but not the configuration, so it wouldn't make any sense to update the existing enable screensaver handler to read the selected screensaver from the configuration. I added another keyboard shortcut for left control + right shift + J to specially enable the Jitter screensaver instead.