Open
Conversation
…helper functions to tilelayer events for map, ajax events for poi search, and inbuilt navigator.onLine online/offline events
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards resolving issue #23.
Added HTML banner, offline-online-pane, added helper functions goOffline, goOnline, and animateOnlineOfflinePane, and bound goOffline and goOnline to the following:
Offline banner is always displayed when error is detected, online is only displayed when status is changed from offline to online (which is the purpose of the wasOnline global variable) so people aren't bothered by repeated messages telling them everything is working.
Not sure what you were intending for the design of the banner, I've made it so it slides down as a solid red/green banner from the top, 100% width and 35px height, stays for 2.5 seconds, then slides back to leave 3px of green or red exposed under the header, to give an ongoing display of connection status. Some pictures from iPhone, Android, desktop Chrome below. Also tested on IE11 and desktop Firefox, haven't seen any problems:
Cheers!