release: v5.x.x #197
Merged
release: v5.x.x #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: group validation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the GroupAdd page to refine validation error messages and UI labels in preparation for the v5.x.x release.
- Updated Yup validation error messages from Japanese to English for consistency.
- Changed the minimum character requirement for question2 from 30 to 20 characters.
- Adjusted FormLabel texts to include minimum character hints.
Comments suppressed due to low confidence (2)
src/pages/Add/GroupAdd/GroupAdd.tsx:326
- [nitpick] There's an inconsistency in language: the error messages in validations have been updated to English while the FormLabel retains Japanese text. Consider unifying the language for a consistent user experience.
<FormLabel>1.1. どこで当団体のことを知りましたか？ [20文字以上]</FormLabel>
src/pages/Add/GroupAdd/GroupAdd.tsx:129
- The minimum length for question2 has been changed from 30 to 20. Please verify that this adjustment aligns with the design requirements.
.min(20, 'question2 must be at least 20 characters'),
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.