Add EntityConfigurationWebView and integrate in dialog #4171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces EntityConfigurationWebView for entity configuration via web view. Integrates a toolbar button in EntityMoreInfoDialogView to present the new configuration view as a sheet.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new EntityConfigurationWebView component that displays entity information in a web view and integrates it into the existing EntityMoreInfoDialogView via a toolbar button. The implementation adds a sheet presentation triggered by a gear icon button.
Key Changes
- Added
EntityConfigurationWebViewfor displaying entity details via web view - Integrated a gear-shaped toolbar button in
EntityMoreInfoDialogViewto present the new configuration view as a sheet - Updated Xcode project file with new source file reference
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
EntityConfigurationWebVIew.swift |
New SwiftUI view that embeds a WebViewController to display entity information using the more-info-dialog query parameter |
EntityMoreInfoDialogView.swift |
Added toolbar button and sheet presentation to launch the new EntityConfigurationWebView |
HomeAssistant.xcodeproj/project.pbxproj |
Project file updated with new source file reference and reordered existing entries |
...ces/App/WebView/ExperimentalSpace/EntityTile/MoreInfoDialog/EntityConfigurationWebView.swift
Show resolved
Hide resolved
...ces/App/WebView/ExperimentalSpace/EntityTile/MoreInfoDialog/EntityConfigurationWebView.swift
Show resolved
Hide resolved
...ces/App/WebView/ExperimentalSpace/EntityTile/MoreInfoDialog/EntityConfigurationWebView.swift
Show resolved
Hide resolved
Sources/App/WebView/ExperimentalSpace/EntityTile/MoreInfoDialog/EntityMoreInfoDialogView.swift
Show resolved
Hide resolved
...ces/App/WebView/ExperimentalSpace/EntityTile/MoreInfoDialog/EntityConfigurationWebView.swift
Show resolved
Hide resolved
...ces/App/WebView/ExperimentalSpace/EntityTile/MoreInfoDialog/EntityConfigurationWebView.swift
Show resolved
Hide resolved
...ces/App/WebView/ExperimentalSpace/EntityTile/MoreInfoDialog/EntityConfigurationWebView.swift
Show resolved
Hide resolved
Renamed EntityConfigurationWebVIew.swift to EntityConfigurationWebView.swift and updated project references to correct the filename typo.
Eliminated the areaName property from EntityConfigurationWebView and its usage. Updated the sheet presentation in EntityMoreInfoDialogView to use presentationDetents and presentationDragIndicator for improved UI behavior.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4171 +/- ##
=======================================
Coverage ? 44.94%
=======================================
Files ? 249
Lines ? 14341
Branches ? 0
=======================================
Hits ? 6446
Misses ? 7895
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces EntityConfigurationWebView for entity configuration via web view. Integrates a toolbar button in EntityMoreInfoDialogView to present the new configuration view as a sheet.
Summary
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes