Skip to content

Conversation

@bgoncal
Copy link
Member

@bgoncal bgoncal commented Jan 6, 2026

Summary

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

Copilot AI review requested due to automatic review settings January 6, 2026 23:19
@bgoncal bgoncal changed the title Update EntityMoreInfoDialogView.swift Remove background from native more info dialog Jan 6, 2026
@bgoncal bgoncal enabled auto-merge (squash) January 6, 2026 23:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the .presentationBackground(Color.clear) modifier from the EntityMoreInfoDialogView, which is displayed as a fullScreenCover with a zoom navigation transition when tapping entity tiles in the experimental space.

  • Removes a presentation background modifier that was making the dialog background transparent

@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@266d41e). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4170   +/-   ##
=======================================
  Coverage        ?   45.00%           
=======================================
  Files           ?      249           
  Lines           ?    14341           
  Branches        ?        0           
=======================================
  Hits            ?     6454           
  Misses          ?     7887           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bgoncal bgoncal merged commit 7474990 into main Jan 6, 2026
21 checks passed
@bgoncal bgoncal deleted the bgoncal-patch-8 branch January 6, 2026 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants