Revise FCM push notification setup steps - #3144
Conversation
Add instruction to create a Firestore database when setting up FCM push notifications
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Android FCM push notification documentation was updated to add a new step for creating a default Firestore database and to renumber the subsequent setup instructions accordingly to maintain correct sequence ordering. ChangesFCM Push Notification Setup Steps
🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I do recall one error related to Firestore, but think it was just an API that needed to be enabled in the Google Cloud project (and then it creates the default Firestore when you try to deploy). Let me double check with a new project tomorrow (but if it's more clicks to enable the API we can also keep this instruction in). |
|
Ah, I'm not sure if I did another deploy after I enabled the API. |
|
Created a new project following the steps in the docs, and then tried to deploy. If you try to speedrun deployment you run into permission issues with service accounts, but ignoring that and waiting a bit more I get the error: Visiting the second URL and enabling the API (there is a blue button for it on that page), waiting a couple of minutes, and deploying again I get a new error which I couldn't quickly resolve: Creating a default Firestore also didn't resolve it, so something else broke. I'm now also encountering this error on my existing project... None of this is related to the Android app however. I suggest moving whatever additional steps end up being needed to the push server's setup (in the readme file). |
Proposed change
The instructions for setting up FCM for Android development currently result in errors for a missing Firestore database. This commit adds an instruction to create a Firestore database when setting up FCM push notifications.
Type of change
Checklist
Summary by CodeRabbit