Skip to content

Revise FCM push notification setup steps - #3144

Open
inukiwi wants to merge 1 commit into
home-assistant:masterfrom
inukiwi:patch-1
Open

Revise FCM push notification setup steps#3144
inukiwi wants to merge 1 commit into
home-assistant:masterfrom
inukiwi:patch-1

Conversation

@inukiwi

@inukiwi inukiwi commented Jun 12, 2026

Copy link
Copy Markdown

Proposed change

The instructions for setting up FCM for Android development currently result in errors for a missing Firestore database. This commit adds an instruction to create a Firestore database when setting up FCM push notifications.

Type of change

  • Document existing features within Home Assistant
  • Document new or changing features for which there is an existing pull request elsewhere
  • Spelling or grammatical corrections, or rewording for improved clarity
  • Editing or restructuring documentation guidelines
  • Changes to the backend of this documentation
  • Remove stale or deprecated documentation

Checklist

  • I have read and followed the documentation guidelines.
  • I have verified that my changes render correctly in the documentation.

Summary by CodeRabbit

  • Documentation
    • Updated Android FCM push notification setup guide with clarified instructions and improved step organization.
    • Added explicit step for creating a default Firestore database in the setup process.
    • Re-organized subsequent steps to follow the new Firestore configuration step in correct order.

Add instruction to create a Firestore database when setting up FCM push notifications
@inukiwi
inukiwi requested a review from a team as a code owner June 12, 2026 16:49
@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 61009c9d-f313-4a2f-89a1-b46d1768e113

📥 Commits

Reviewing files that changed from the base of the PR and between 4679f11 and aceb2c8.

📒 Files selected for processing (1)
  • docs/android/tips/fcm_push_notification.md

📝 Walkthrough

Walkthrough

The Android FCM push notification documentation was updated to add a new step for creating a default Firestore database and to renumber the subsequent setup instructions accordingly to maintain correct sequence ordering.

Changes

FCM Push Notification Setup Steps

Layer / File(s) Summary
Setup instructions with Firestore prerequisite
docs/android/tips/fcm_push_notification.md
New step inserted to create a default Firestore database (enabling the Cloud Firestore API), with Android app configuration, push notification service deployment, and notification URL steps renumbered to follow. The "Download and place the google-services.json File" section also renumbered to reflect the updated sequence.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: revising the steps for FCM push notification setup documentation.
Description check ✅ Passed The description follows the template structure, includes a clear proposed change explaining the Firestore database requirement, and indicates the appropriate type of change with required checklist items completed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@TimoPtr TimoPtr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I never did the setup myself so I'll rely on @jpelgrom to validate that it is the right way.

@jpelgrom

Copy link
Copy Markdown
Member

I do recall one error related to Firestore, but think it was just an API that needed to be enabled in the Google Cloud project (and then it creates the default Firestore when you try to deploy). Let me double check with a new project tomorrow (but if it's more clicks to enable the API we can also keep this instruction in).

@inukiwi

inukiwi commented Jun 17, 2026

Copy link
Copy Markdown
Author

Ah, I'm not sure if I did another deploy after I enabled the API.
After I enabled it I created the database manually based on the logs in Home Assistant so that could definitely be the case.

@jpelgrom

Copy link
Copy Markdown
Member

Created a new project following the steps in the docs, and then tried to deploy. If you try to speedrun deployment you run into permission issues with service accounts, but ignoring that and waiting a bit more I get the error:

Error: Request to https://firebasehosting.googleapis.com/v1beta1/projects/-/sites/ha-fcm-test/versions/265b91501f9160b8?updateMask=status%2Cconfig had HTTP Error: 403, Cloud Run Admin API has not been used in project 761946187780 before or it is disabled. Enable it by visiting https://console.developers.google.com/apis/api/run.googleapis.com/overview?project=761946187780 then retry. If you enabled this API recently, wait a few minutes for the action to propagate to our systems and retry.

Visiting the second URL and enabling the API (there is a blue button for it on that page), waiting a couple of minutes, and deploying again I get a new error which I couldn't quickly resolve:

Error: Request to https://firebasehosting.googleapis.com/v1beta1/projects/-/sites/ha-fcm-test/versions/9d3e09794c40626b?updateMask=status%2Cconfig had HTTP Error: 400, Cloud Run service `mobile-push` does not exist in region `europe-west1` in this project.

Creating a default Firestore also didn't resolve it, so something else broke. I'm now also encountering this error on my existing project...

None of this is related to the Android app however. I suggest moving whatever additional steps end up being needed to the push server's setup (in the readme file).

@silamon
silamon requested a review from jpelgrom July 24, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants