Add optional speed parameter to cover movement actions - #176231
Open
wollew wants to merge 37 commits into
Open
Conversation
home-assistant
Bot
added
cla-signed
core
has-tests
integration: cover
new-feature
labels
Contributor
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
wollew
marked this pull request as ready for review
July 10, 2026 19:26
joostlek
previously requested changes
Jul 11, 2026
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds optional, entity-defined speed selection to cover movement actions.
Changes:
- Adds speed capability metadata and validation.
- Exposes speed fields in service definitions.
- Adds service and validation tests.
Outstanding feedback: Translation-reference clarification remains unresolved in this review thread.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
cover/__init__.py |
Implements speed validation and dispatch. |
cover/const.py |
Defines speed attributes. |
cover/services.yaml |
Exposes speed service fields. |
cover/strings.json |
Adds field and error translations. |
cover/common.py |
Extends test cover behavior. |
cover/conftest.py |
Adds a speed-capable fixture. |
cover/test_init.py |
Tests speed services and validation. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Member
|
CLA is clean |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Suppressed comments (4)
homeassistant/components/cover/services.yaml:17
- The selector references
attribute: speed, but the entity exposes the list assupported_speeds(capability attribute). As written, the UI will look up a non-existent attribute. Update the selector to referencesupported_speeds(or adjust the selector type if the intent is to select from a list capability attribute).
fields:
speed:
example: "fast"
filter:
supported_features:
- cover.CoverEntityFeature.SPEED
selector:
state:
attribute: speed
tests/components/cover/test_init.py:252
- This test file imports
ATTR_POSITIONbut still uses the literal key\"position\"in a couple of service calls. UsingATTR_POSITIONconsistently will avoid accidental typos and make future refactors (renames/aliases) safer.
{ATTR_ENTITY_ID: speed_cover.entity_id, "position": 75, ATTR_SPEED: "default"},
tests/components/cover/test_init.py:315
- This test file imports
ATTR_POSITIONbut still uses the literal key\"position\"in a couple of service calls. UsingATTR_POSITIONconsistently will avoid accidental typos and make future refactors (renames/aliases) safer.
{ATTR_ENTITY_ID: ent2.entity_id, "position": 49, ATTR_SPEED: "ignore"},
homeassistant/components/cover/init.py:357
- Speed validation is currently case-sensitive. Since
speedultimately comes from user/service input (and demo code normalizes via.upper()for Enum lookup), consider normalizing (e.g.,speed = speed.lower().strip()and storingsupportednormalized similarly) to make validation more robust and avoid surprising errors from casing/whitespace.
def _valid_speed_or_raise(self, speed: str, supported: list[str]) -> None:
"""Raise ServiceValidationError if speed is not in the supported list."""
if speed not in supported:
supported_str = ", ".join(supported)
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Suppressed comments (5)
homeassistant/components/demo/cover.py:166
- Indexing the enum via
Speed[...]will raiseKeyErrorif an invalid/unexpectedspeedreaches these methods (including case/format mismatches). Even though the new service handlers validate for normal service calls, these entity methods can still be invoked from other code paths/tests. Consider defensively handling unknown speeds (e.g., fallback toDEFAULTor raising aServiceValidationErrorwith the same translation key) to avoid uncaught exceptions.
self._current_speed = Speed[kwargs.get(ATTR_SPEED, "DEFAULT").upper()]
homeassistant/components/demo/cover.py:192
- Indexing the enum via
Speed[...]will raiseKeyErrorif an invalid/unexpectedspeedreaches these methods (including case/format mismatches). Even though the new service handlers validate for normal service calls, these entity methods can still be invoked from other code paths/tests. Consider defensively handling unknown speeds (e.g., fallback toDEFAULTor raising aServiceValidationErrorwith the same translation key) to avoid uncaught exceptions.
self._current_speed = Speed[kwargs.get(ATTR_SPEED, "DEFAULT").upper()]
homeassistant/components/demo/cover.py:212
- Indexing the enum via
Speed[...]will raiseKeyErrorif an invalid/unexpectedspeedreaches these methods (including case/format mismatches). Even though the new service handlers validate for normal service calls, these entity methods can still be invoked from other code paths/tests. Consider defensively handling unknown speeds (e.g., fallback toDEFAULTor raising aServiceValidationErrorwith the same translation key) to avoid uncaught exceptions.
self._current_speed = Speed[kwargs.get(ATTR_SPEED, "DEFAULT").upper()]
tests/components/cover/test_init.py:252
- These service payloads use the literal key
\"position\"instead of the importedATTR_POSITIONconstant. UsingATTR_POSITIONconsistently avoids typos and keeps tests aligned with the domain API surface.
{ATTR_ENTITY_ID: speed_cover.entity_id, "position": 75, ATTR_SPEED: "default"},
tests/components/cover/test_init.py:318
- These service payloads use the literal key
\"position\"instead of the importedATTR_POSITIONconstant. UsingATTR_POSITIONconsistently avoids typos and keeps tests aligned with the domain API surface.
{ATTR_ENTITY_ID: ent2.entity_id, "position": 49, ATTR_SPEED: "ignore"},
Member
|
In general this looks good. The selector config comment above needs to be addressed. |
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
Done.
Agreed, it feels weird but I couldn't find anywhere where it causes an actual problem/weirdness. |
gjohansson-ST
requested changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
This PR adds an optional speed parameter to cover open/close/set_position actions, as discussed in this architecture proposal. I've tested it with the velux integration to work as expected. This is my first PR for one of the base entities, so bear with me if this is maybe not quite up to standard, especially the tests. Happy to take hints and improve.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: