Update README with migration guide for deprecated action - #304
Conversation
Added migration guide for deprecated home-assistant/builder action.
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
home-assistant
Bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
Added note about workflow supporting push targets.
eshattow
left a comment
eshattow
left a comment
There was a problem hiding this comment.
I suggest appending to the existing note with simple additional sentence "This workflow works similarly for push targets e.g. to build and publish an image on every git push." It is strange looking to me to see several footnotes ahead of the topic of discussion.
sairon
left a comment
sairon
left a comment
There was a problem hiding this comment.
I think the note is slightly misleading, ideally for push it will need some extra handling. Maybe just default to Git commit SHA if the release version is undefined? Ideally I'd like to see a PoC it works then.
|
|
||
| The following example workflow builds multi-arch container images when a GitHub release is published. It prepares a build matrix, builds per-architecture images in parallel (e.g., `ghcr.io/owner/amd64-my-image`, `ghcr.io/owner/aarch64-my-image`), and then combines them into a single multi-arch manifest (`ghcr.io/owner/my-image`). | ||
|
|
||
| Note that the workflow below works also for `push` targets in case you want to build and publish an image on every git push. |
There was a problem hiding this comment.
Well, not really, it will need few more changes, especially because ${{ github.event.release.tag_name }} won't be defined. While it will probably not fail, the behavior might not be what the developer expects (as version will be completely empty and images will be tagged only with the latest tag).
There was a problem hiding this comment.
yes I tried using that workflow with the on: push trigger and I confirm that the ${{ github.event.release.tag_name }} will be empty and the image will be labelled only with the latest tag.I added a note about that...
sairon
changed the title
3 participants
Added migration guide for deprecated home-assistant/builder action.