feat: test central host UI #81
Open
FentPams wants to merge 1 commit into
Open
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
Collaborator
Author
|
@ramboz Hosting on github pages is workable :) Appreciate your thoughts here. |
ramboz
reviewed
Aug 1, 2024
ramboz
left a comment
Collaborator
There was a problem hiding this comment.
Great :)
You can probably create a new branch then directly in the aem experimentation repo for the pages, and I'll configure the repo to point to that branch for the code. That way we can load directly from https://adobe.github.io/aem-experimentation/preview.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for testing the feasibility of using central-host plugin's UI files (preview.js, preview.css) on GitHub Pages (https://github.com/FentPams/FentPams.github.io). The goal is to see if we can effectively host and display these files through GitHub Pages and use this as a reference for future implementations on admin.aem.live.
preivew.jsandpreivew.cssfiles on Github pages:Code changes:
index.js, passing the context needed for preview.js, and import the url that points to the remote preview.js:Screenshots of changing overlay pill's color in preview.css
Test URLs: