Skip to content

ACCS-871: Add Error State Handling on /pay Page - #1303

Open
yutingjiangYTJ wants to merge 10 commits into
pay-by-linkfrom
ACCS-871
Open

ACCS-871: Add Error State Handling on /pay Page#1303
yutingjiangYTJ wants to merge 10 commits into
pay-by-linkfrom
ACCS-871

Conversation

@yutingjiangYTJ

@yutingjiangYTJ yutingjiangYTJ commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

Test URLs:

Ticket:
https://jira.corp.adobe.com/browse/ACCS-871

Changes

Shared error modules in blocks/commerce-pay-by-link/errors/:

  • error-states.js — 9 states, backend code + HTTP status mapping (404/409/410), resolveOnRetry()
  • error-card.js — accessible error UI (role="alert", focus management, Elsie Button CTAs), plus renderMappedError() for API failures
  • Block integration:
    • Pre-flight errors (missing/malformed token) → renderErrorCard()
    • payByLinkOrder failures → renderMappedError() with automatic retry for generic errors
  • i18n via PayByLink.* da.live placeholders (including ErrorGenericTitle / ErrorGenericBody / ErrorTryAgainLabel)
  • Cypress E2E: verifyPayByLinkPageShell, verifyPayByLinkOrderSummary, verifyPayByLinkErrorStates (not-found, expired, already-completed, generic + retry)
  • Block README documenting states, exports, and i18n keys
PaymentLink Missing PaymentLink Not Valid Payment Not Found

@aem-code-sync

aem-code-sync Bot commented Jun 15, 2026

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run all PSI checks
  • Re-run failed PSI checks
  • Re-sync branch
Commits

@aem-code-sync

aem-code-sync Bot commented Jun 15, 2026

Copy link
Copy Markdown
Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@yutingjiangYTJ
yutingjiangYTJ marked this pull request as ready for review June 22, 2026 14:58
@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown

📝 Block Changes Detected

This PR contains changes to the following blocks:

  • blocks/commerce-pay-by-link/ (has README.md)
  • blocks/commerce-pay-by-link-confirmation/ (has README.md)

📋 README Requirements

Please ensure the README.md for each changed block includes:

  • Overview: Clear description of the block's purpose and functionality
  • Configuration: All configuration options, their types, defaults, and side effects
  • Integration: URL parameters, localStorage usage, and event handling
  • Behavior Patterns: User interaction flows and page context detection
  • Error Handling: How the block handles errors and fallback scenarios

✅ All blocks have README files

Please review and update the README files to ensure they accurately reflect any changes made to the blocks.


This comment was automatically generated by the Block README Check workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant