Change action from plugins_loaded to after_setup_theme#59
Open
nicoladj77 wants to merge 1 commit intohissy:masterfrom
Open
Change action from plugins_loaded to after_setup_theme#59nicoladj77 wants to merge 1 commit intohissy:masterfrom
nicoladj77 wants to merge 1 commit intohissy:masterfrom
Conversation
There are some setups where you load the plugin inside the theme. In those cases, the importer is not setup, I think it would be better to use after_setup_theme as the action to hook into.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some setups where you load the plugin inside the theme. In those cases, the importer is not setup, I think it would be better to use after_setup_theme as the action to hook into.