Open
Conversation
With the proposed changes here to RS_CSV_Importer::dispatch() merged into master, you could then use the technique seen in [this Gist](https://gist.github.com/hissy/199ad9be855ec9be1e54) to extend header(), footer(), greet(), and import() in the same way.
Owner
|
I think this is too much extensibility for my plugin. Could you show me an example to use this? |
Author
|
It'll be a couple days before I have it coded, but I need to modify the import() function to iterate through a directory of CSV files, and pass each one off to process_posts(). The greet, header, and footer additions were simply an effort to make the change applicable to a wider audience. I can update the pull request in about a week or so when I have the "loop through a directory of CSV files" extension coded. |
Owner
|
Actually, I think I did mistake to add this function (replace importer class), because it is too complicated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the proposed changes here to RS_CSV_Importer::dispatch() merged into master, you could then use the technique seen in this Gist to extend header(), footer(), greet(), and import() in the same way.