Skip to content

ci: enforce Go vet warning gate - #4193

Open
EndlessSeeker wants to merge 1 commit into
higress-group:mainfrom
EndlessSeeker:codex/openssf-warning-gate
Open

ci: enforce Go vet warning gate#4193
EndlessSeeker wants to merge 1 commit into
higress-group:mainfrom
EndlessSeeker:codex/openssf-warning-gate

Conversation

@EndlessSeeker

Copy link
Copy Markdown
Collaborator

What this changes

  • replaces the empty core lint job with a required Go vet run after the normal prebuild step
  • removes the duplicate empty lint placeholder from the plugin workflow
  • fixes all five findings reported by the enforced vet scope
  • adds a reusable make lint.vet target covering cmd, pkg, registry, and conformance code

OpenSSF evidence

This provides an enforced FLOSS warning tool and a zero-warning baseline for the OpenSSF Best Practices warnings and warnings_fixed criteria. Broader heuristic linters can be enabled incrementally without weakening this required gate.

Verification

  • make lint.vet
  • go test ./pkg/kube ./registry/nacos/mcpserver ./test/e2e/conformance/tests -run ^$
  • git diff --check

@CLAassistant

CLAassistant commented Jul 23, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@codecov-commenter

codecov-commenter commented Jul 23, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@c8b8279). Learn more about missing BASE report.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4193   +/-   ##
=======================================
  Coverage        ?   50.76%           
=======================================
  Files           ?       88           
  Lines           ?    13410           
  Branches        ?        0           
=======================================
  Hits            ?     6808           
  Misses          ?     6154           
  Partials        ?      448           
Files with missing lines Coverage Δ
pkg/kube/client.go 0.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Change-Id: Ie9e0aa4f5d64fbccd316d6755a2f9a1c0237518d
Signed-off-by: EndlessSeeker <1766508902@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants