Skip to content

Library production build error on latest version 3.1.0 #345

Open

Description

@joeveiga

Describe the bug

It works fine up to v3.0.0. Latest update caused an error on our build pipeline with what it seems to be breaking changes introduced on v3.1.0.

An unhandled exception occurred: node_modules/highcharts-angular/lib/highcharts-chart.component.d.ts:24:18 - 
error TS2314: Generic type 'ɵɵComponentDeclaration' requires 7 type argument(s).

24     static ɵcmp: i0.ɵɵComponentDeclaration<
  HighchartsChartComponent,
  "highcharts-chart",
  never, { 
    "Highcharts": "Highcharts";
    "constructorType": "constructorType";
    "callbackFunction": "callbackFunction";
    "oneToOne": "oneToOne";
    "runOutsideAngular": "runOutsideAngular";
    "options": "options";
    "update": "update"; 
  }, { 
    "updateChange": "updateChange";
    "chartInstance": "chartInstance"; 
  }, 
  never, 
  never, 
  false, 
  never
>;

Expected behavior

Minor version changes to be compatible.

Setup used

  • NodeJS version: 14

  • Angular version: 13.3.4

  • TypeScript version: 4.6.4

{
  "compileOnSave": false,
  "compilerOptions": {
    "baseUrl": "./",
    "outDir": "./dist/out-tsc",
    "sourceMap": true,
    "declaration": false,
    "moduleResolution": "node",
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "esModuleInterop": true,
    "resolveJsonModule": true,
    "allowSyntheticDefaultImports": true,
    "module": "es2020",
    "target": "es2017",
    "typeRoots": ["node_modules/@types"],
    "lib": ["es2017", "dom", "es2019", "ESNext.BigInt"],
    }
  },
  "angularCompilerOptions": {
    "strictTemplates": false,
    "compilationMode": "partial"
  }
}

Activity

  1. jthorsen commented on Feb 3, 2023

    @jthorsen

    Angular dependency was changed from 13 to 14. I had to use ~3.0.0 instead of ^3.0.0 to avoid 3.1.x

  2. karolkolodziej commented on Feb 3, 2023

    @karolkolodziej
    Member

    @jthorsen that is correct my mistake!
    For Angular version 13 please use highcharts-angular in version 3.0.0

  3. izbushka commented on Feb 3, 2023

    @izbushka

    The build also fails on angular 14.2.12

  4. karolkolodziej commented on Feb 3, 2023

    @karolkolodziej
    Member

    You are right, I see a similar issue with Angular 14... in 15 it looks alright.

    I will wait for the Highcharts v11 release (which should be in a couple of weeks) and after that, I will release a new major version of this wrapper.

    I apologize for the inconvenience- right now it looks like using version 3.0.0 is a valid solution for older Angular versions.

  5. minijus commented on May 11, 2023

    @minijus

    @karolkolodziej are there still plans to release new major version of highcharts-angular that works with Angular 14+ (including v16)?

  6. karolkolodziej commented on May 15, 2023

    @karolkolodziej
    Member

    Hi @minijus! As far as I see, you can correctly use the highcharts-angular with the Angular 16- demo.

    But nevertheless, in the nearest future, we will release a new version 😄

  7. self-assigned this
    on May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions