retrospectively mark operations @Incubating #11411
Merged
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New API operations should generally be marked @Incubating, especially when they occur on prominent interfaces like Session, Query, or SessionFactory. These ones weren't. (Sometimes we forget.) And there was a reason they should have been: their signatures are not type safe, featuring an unbound type parameter in the return type, even though their type argument is reified internally. So a RootGraph<Book> can masquerade as a RootGraph<Author>. This is a big antipattern that I've been trying to systematically root out throughout the whole codebase.
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New API operations should generally be marked
@Incubating, especially when they occur on prominent interfaces likeSession,Query, orSessionFactory. These ones weren't. (Sometimes we forget.)And there was a reason they should have been: their signatures are not type safe, featuring an unbound type parameter in the return type, even though their type argument is reified internally. So a
RootGraph<Book>can masquerade as aRootGraph<Author>. This is a big antipattern that I've been trying to systematically root out throughout the whole codebase.[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.