-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
HHH-19846 Drop JUnit 4 usage #11105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jrenaat
wants to merge
20
commits into
hibernate:main
Choose a base branch
from
jrenaat:HHH-19846_removeJunit4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
HHH-19846 Drop JUnit 4 usage #11105
+1,966
−2,555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hibernate-core/src/test/java/org/hibernate/orm/test/annotations/HHH16122Test.java
Dismissed
Show dismissed
Hide dismissed
08beb10
to
4f3f96b
Compare
.../src/test/java/org/hibernate/orm/test/dialect/functional/SQLServerDialectPaginationTest.java
Dismissed
Show dismissed
Hide dismissed
aa9d841
to
8465b17
Compare
Signed-off-by: Jan Schatteman <[email protected]>
Signed-off-by: Jan Schatteman <[email protected]>
Signed-off-by: Jan Schatteman <[email protected]>
Signed-off-by: Jan Schatteman <[email protected]>
Signed-off-by: Jan Schatteman <[email protected]>
Signed-off-by: Jan Schatteman <[email protected]>
Signed-off-by: Jan Schatteman <[email protected]>
Signed-off-by: Jan Schatteman <[email protected]>
Signed-off-by: Jan Schatteman <[email protected]>
Signed-off-by: Jan Schatteman <[email protected]>
…meout Signed-off-by: Jan Schatteman <[email protected]>
Signed-off-by: Jan Schatteman <[email protected]>
Signed-off-by: Jan Schatteman <[email protected]>
Signed-off-by: Jan Schatteman <[email protected]>
Signed-off-by: Jan Schatteman <[email protected]>
Signed-off-by: Jan Schatteman <[email protected]>
Signed-off-by: Jan Schatteman <[email protected]>
Signed-off-by: Jan Schatteman <[email protected]>
0cda6aa
to
e804b21
Compare
//tag::collections-collection-proxy-usage-example[] | ||
Person person = entityManager.find(Person.class, 1L); | ||
//Throws java.lang.ClassCastException: org.hibernate.collection.internal.PersistentBag cannot be cast to java.util.ArrayList | ||
ArrayList<String> phones = (ArrayList<String>) person.getPhones(); |
Check notice
Code scanning / CodeQL
Unread local variable Note test
Variable 'ArrayList phones' is never read.
...src/test/java/org/hibernate/orm/test/mapping/collections/BasicTypeElementCollectionTest.java
Dismissed
Show dismissed
Hide dismissed
...e/src/test/java/org/hibernate/orm/test/mapping/collections/OrderColumnListIndexBaseTest.java
Fixed
Show fixed
Hide fixed
...e/src/test/java/org/hibernate/orm/test/mapping/collections/OrderColumnListIndexBaseTest.java
Fixed
Show fixed
Hide fixed
Signed-off-by: Jan Schatteman <[email protected]>
b744e85
to
bf4e6b6
Compare
….custom.basic/declaredtype/parameterized Signed-off-by: Jan Schatteman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19846