[WIP] Add zip command#14
Open
hgoldstein wants to merge 1 commit into
Open
Conversation
* Works similar to `pdf`
hgoldstein
commented
Feb 7, 2017
|
|
||
| zip: { | ||
| - 'reveal-js-presentation.zip': [ | ||
| + '/reveal-js-presentation.zip': [ |
Owner
Author
There was a problem hiding this comment.
- I wish there was a better way to represent a diff of a diff
- I do this because currently I'm not sure how one writes to a union-fs, or if there's a way to set up the union to say "writes go to this directory"
Collaborator
There was a problem hiding this comment.
Write to one of the component directories. The unioned directory is read only.
hgoldstein
commented
Feb 7, 2017
| import scripts.setup as setup | ||
| from scripts.config import image_name | ||
|
|
||
| def run(slides, local): |
Owner
Author
There was a problem hiding this comment.
Now that we use this logic multiple times it might be time for a cleanup of scripts.
Collaborator
|
This doesn't actually work because the markdown needs to get turned into HTML client side, and the client makes javascript requests to load the markdown files: |
Owner
Author
|
Yup; and I haven't been noticing cause I've been |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pdfWill resolve #6, IMO.