fix(feedback): add transfer evidence cards#47
Open
rodboev wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #38
Summary
Add a per-generation
transfer_evidence.jsonartifact that separates reusable improvements from task-specific residue before the next feedback handoff consumes generation output. The new artifact becomes the structured reuse boundary for feedback-context andcontext.md, whileimprovement.mdstays the human-authored analysis file.Tighten the transfer-evidence heuristic so higher-is-better metrics only count as reusable when they strictly improve, and percent-formatted scores are parsed instead of silently dropping back to unscored reuse decisions.
Why
Current
origin/mainonly carries forward raw execution and evaluation context plus a truncated carryover fromimprovement.md. That forces later generations to infer what was actually reusable, which can flatten score gains, formatting wins, task-specific residue, and unsupported claims into the same channel.Scope
transfer_evidence.jsonnext toresults.jsonafter each generationimprovement.mdbulletsTRANSFER EVIDENCEsection in feedback contextcontext.md#36may require a rebase because it touches the same files, but this PR does not expand into that separate leak-fix scopeTest plan
python -m pytest tests/test_orchestrator_helpers.py tests/test_feedback_context_golden.py tests/test_context_manager.py tests/test_context_golden.py tests/test_prompts_snapshot.py tests/test_generation_loop.py -q, passed, 31 passed in 0.17s; pytest emitted the recurring Windows temp-cleanup warning forC:\Users\Rod\AppData\Local\Temp\pytest-of-Rod\pytest-currentafter the successful exitpython -m ruff check sia/layout.py sia/results.py sia/orchestrator.py sia/context_manager.py sia/prompts.py tests/test_orchestrator_helpers.py tests/test_feedback_context_golden.py tests/test_context_manager.py tests/test_context_golden.py tests/test_prompts_snapshot.py tests/test_generation_loop.py, passedpython -m ruff format sia/layout.py sia/results.py sia/orchestrator.py sia/context_manager.py sia/prompts.py tests/test_orchestrator_helpers.py tests/test_feedback_context_golden.py tests/test_context_manager.py tests/test_context_golden.py tests/test_prompts_snapshot.py tests/test_generation_loop.py --check, passed, 11 files already formattedty check sia/, exited cleanly with pre-existing unresolved-import warnings in optionalopenhandsandpydantic_aiintegrations outside this change