Optimize encodings of coherence and acyclicity (mostly IDL)#1015
Open
ThomasHaas wants to merge 3 commits intodevelopmentfrom
Open
Optimize encodings of coherence and acyclicity (mostly IDL)#1015ThomasHaas wants to merge 3 commits intodevelopmentfrom
ThomasHaas wants to merge 3 commits intodevelopmentfrom
Conversation
Collaborator
Author
|
See |
Added optimization also to idl2Sat encoding
c7d559f to
95b96b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a little trick to make the ordering constraints of some must-edges unconditional, i.e., it changes the encoding from
exec(x) /\ exec(y) => clk(x) < clk(y)toclk(x) < clk(y)if possible.The argument for when this can be done is quite subtle.
Most benefit is expected on eager encodings, especially for SC where I saw improvements in the range of 10-30%.
I think it might be worth having an SVCOMP run with this branch.
The optimization might also be applicable to the SAT encodings for acyclicty. I have not thought about this yet though.EDIT: I have added the same optimization to the SAT encoding for acyclicity. I also saw some improvement, but not as big as in the IDL case.