Support annotation link dependencies - #210
Merged
Merged
Conversation
finn-ball
marked this pull request as ready for review
August 4, 2026 09:15
dzbarsky
reviewed
Aug 5, 2026
| if is_proc_macro: | ||
| (_rust_proc_macro if skip_deps_verification else rust_proc_macro)(**kwargs) | ||
| else: | ||
| kwargs["link_deps"] = link_deps |
Member
There was a problem hiding this comment.
can you leave a comment explaining why rust_proc_macro doesn't need link_deps? Also it seems odd that it's silently ignored if it's specified, perhaps we should hard-fail and tell you to remove the annotation?
Contributor
Author
There was a problem hiding this comment.
You can't hard fail. Some packages can include rust_proc_macro, rust_binary and rust_library. Added a comment instead.
finn-ball
force-pushed
the
finn/annotation-link-deps
branch
2 times, most recently
from
August 5, 2026 09:56
dfe2ba8 to
4bfc564
Compare
finn-ball
force-pushed
the
finn/annotation-link-deps
branch
from
August 5, 2026 10:00
4bfc564 to
6b269cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
link_depsand platform-specificlink_deps_selectannotation attributes.rust_librarytargets.