fix: resolve transitive external path dependencies - #199
Open
snowp wants to merge 1 commit into
Open
Conversation
Walk external path manifests with cargo metadata --no-deps so lockfile path packages can be resolved without loading the complete dependency graph. Use the collected metadata for external Cargo workspaces, where package manifests may inherit dependency declarations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Walk external path manifests with cargo metadata --no-deps so lockfile path packages can be resolved without loading the complete dependency graph. Use the collected metadata for external Cargo workspaces, where package manifests may inherit dependency declarations.
This addresses #181 and additionally handles pointing at workspaces outside of the cargo workspace, both of which are part of our local dev story with Cargo so they seem reasonable to me to support in rules_rs, but feel free to push back if this is too crazy. Tested this in https://github.com/bitdriftlabs/capture-sdk which employs this kind of pattern to support local dev against https://github.com/bitdriftlabs/shared-core.
Added a test that demonstrates the transitive path workspace setup, including placing the cargo workspace outside the test/ Bazel workspace to validate that we can handle depending on repos outside of the repo.