Sanitize macOS rust-lld RPATH in generated toolchain - #143
Open
dzbarsky wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
rust-lldbinaries include an absoluteLC_RPATHpointing at the Rust CI builder (/Users/runner/work/rust/rust/build/<triple>/llvm/lib), which leaks build provenance and creates a latent dylib-search risk.Description
_MACOS_RUST_LLD_BUILD) that provides agenrule(name = "sanitize-rust-lld")which copies the upstreamrust-lldand removes the leaked RPATH when present using@llvm//tools:llvm-otooland@llvm//tools:llvm-install-name-tool.include_linkerconditional so non-macOS toolchains continue to use the upstreamBUILD_for_compilerlinker target while macOS toolchains append the sanitizedrust-lldfilegroup.rust-lldfilegroup interface and its auxiliary linker data so consumers see the same targets while macOS gets the sanitized binary.Testing
bazel query //rs/private:rustc_repositoryto validate repository rule visibility and this succeeded.bazel build //.tmp_rust_lld_build_check:rust-lldand the build completed successfully.buildifierinvocationbazel run @buildifier_prebuilt//:buildifier -- /workspace/rules_rs/rs/private/rustc_repository.bzland it ran successfully.git diff --checkto ensure there are no whitespace/errors and it succeeded.Codex Task