Fix fmin/fmax movability flags#145
Merged
Merged
Conversation
Fix movability flags for `pow` that straddles zero
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
fmin,fmax, andfdim, which were failing the new refinement tests of #143. Basically the issue is that movability forfmin(and the others) is actually asymmetric. Consider the low vs high endpoints of fmin(x, y). The low endpoint is fixed if the smaller low endpoint of x and y is fixed. But the high endpoint is fixed only if both endpoints are fixed (or in a few other cases that don't seem worth bothering with). This asymmetry wasn't captured by the code, which just usedendpoint-minfor both endpoints, and that resulted in fixed endpoints that weren't supposed to be fixed.