Implements memory profiling - #120
Conversation
pavpanchekha
left a comment
There was a problem hiding this comment.
Great but has a major bug. Also check the documentation. If we document the struct we will need to 1) update the documentation and 2) bump the version number, since it's changed.
I looked for the documentation files to update, but wasn't able to find them. Also, by bumping the version number, do you mean the version (define collection "rival")
(define version "2.2")
(define license 'MIT) |
|
The documentation is in Here's my suggestion: instead of exporting |
pavpanchekha
left a comment
There was a problem hiding this comment.
All good on code but needs version bump, provide changes, and doc changes
pavpanchekha
left a comment
There was a problem hiding this comment.
Looks good. I would not document make-execution and otherwise if the nightlies and tests are good let's just merge.
Implements per-op memory profiling to show in the herbie report.
There is a corresponding herbie branch that implements this into the report.