Skip to content

Small suggestion for sc3_prepare() documentation #80

Description

@PeteHaitch

Hi,

Thanks for your work developing SC3!

It might be worth noting that sc3_prepare() adds the sc3_gene_filter column to rowData(object) if gene_filter = TRUE (in addition to creating and populating the metadata(object)).
I had trouble tracking down an error (a user error on my part) because I ran sc3_estimate_k() before and after running sc_prepare() and obtained different values due to the gene_filter; I couldn't figure out how to reconcile the two result based on the docs but realised the source (and my error) once I compared the before/after objects using all.equal().

Cheers,
Pete

Activity

changed the title [-]Documentation of sc3_prepare()[/-] [+]Small suggestion for sc3_prepare() documentation[/+] on Sep 25, 2018

wikiselev commented on Oct 8, 2018

@wikiselev
Member

Hi Pete, thanks for your feedback! Could you please create a pull request? (sorry, I literally have no time to work on SC3 anymore...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions