Skip to content

Update dev dependencies and clear all npm audit advisories#38

Merged
helly25 merged 2 commits into
mainfrom
chore/dep-updates-security
May 30, 2026
Merged

Update dev dependencies and clear all npm audit advisories#38
helly25 merged 2 commits into
mainfrom
chore/dep-updates-security

Conversation

@helly25
Copy link
Copy Markdown
Owner

@helly25 helly25 commented May 30, 2026

Summary

Clears all npm audit advisories and brings the dev toolchain up to date. All affected packages are devDependencies — the extension declares no runtime dependencies, so none of this ships in the published VSIX. This is purely about the build/test toolchain and the Dependabot/npm audit reports.

Scope per request: security fixes + updates within current major (no eslint 10, TypeScript 6, glob 13, or @types/vscode bump).

Advisories fixed (was 5, now 0)

Package Severity Fix
serialize-javascript high mocha 10→11 + override ^7.0.5
brace-expansion moderate transitive updates
diff low override ^8.0.3

npm audit fix --force was not used — it would have downgraded mocha to 11.3.0. Even mocha 11.7.6 still resolves vulnerable serialize-javascript/diff, so those are pinned via npm overrides.

Dependency bumps (all within current major)

@eslint/js / eslint → 9.39 · @typescript-eslint/* + typescript-eslint → 8.60 · typescript → 5.9 · @types/node → 22.19 · @types/mocha → 10.0.10 · @vscode/test-electron → 2.5.2 · globals → 15.15 · mocha → 11.7.6

tsconfig

Added "skipLibCheck": true. TypeScript 5.9's stricter built-in iterator typing rejects a bundled lru-cache .d.ts (a transitive of glob) — not our code. skipLibCheck is the standard remedy and ships in the official yo code extension template.

Verification

  • npm auditfound 0 vulnerabilities
  • npm run compile
  • npm run lint
  • npm run test:local ✅ (3 passing)

Held back (per "security + safe" scope)

eslint 10 (crashes on this project's flat config — confirmed separately), TypeScript 6, glob 13, globals 17, @types/node 25, and @types/vscode 1.120 (tied to engines.vscode). Happy to do these in a follow-up if wanted.

🤖 Generated with Claude Code

All packages here are devDependencies (the extension has no runtime deps), so
none of this ships in the VSIX, but it clears the Dependabot/npm audit reports.

- Bump dev deps to the latest within their current major: @eslint/js, eslint
  9.39, @typescript-eslint/* + typescript-eslint 8.60, typescript 5.9,
  @types/node 22.19, @types/mocha, @vscode/test-electron, globals.
- Bump mocha 10 -> 11 (clears the high-severity serialize-javascript advisory).
- Add npm `overrides` for serialize-javascript ^7.0.5 and diff ^8.0.3, since
  even mocha 11 still resolves vulnerable transitives; `npm audit fix --force`
  would instead downgrade mocha.
- Add `skipLibCheck` to tsconfig: TypeScript 5.9's stricter iterator typing
  rejects a bundled lru-cache .d.ts (a transitive of glob). skipLibCheck is the
  standard fix and is part of the official VS Code extension template.

`npm audit` now reports 0 vulnerabilities; compile, lint, and tests pass.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@helly25 helly25 requested a review from Fab-Cat May 30, 2026 18:23
Fab-Cat
Fab-Cat previously approved these changes May 30, 2026
# Conflicts:
#	package-lock.json
#	package.json
@helly25 helly25 enabled auto-merge (squash) May 30, 2026 18:26
@helly25 helly25 requested a review from Fab-Cat May 30, 2026 18:26
@helly25 helly25 merged commit 3d1fbce into main May 30, 2026
2 checks passed
@helly25 helly25 deleted the chore/dep-updates-security branch May 30, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants