Skip to content

Conversation

@fraggerfox
Copy link
Collaborator

  • Add configuration for psalm
  • Add configuration for phpstan

@fraggerfox fraggerfox self-assigned this Dec 17, 2024
@codecov
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/Type/AuthUpdates.php 0.00% 10 Missing ⚠️
Files with missing lines Coverage Δ Complexity Δ
src/Exception/CallbackException.php 100.00% <ø> (ø) 2.00 <0.00> (ø)
src/Exception/SameSiteCallbackException.php 0.00% <ø> (ø) 1.00 <0.00> (ø)
src/Handler/Callback.php 66.66% <100.00%> (ø) 38.00 <4.00> (ø)
src/Handler/Logout.php 100.00% <100.00%> (ø) 4.00 <0.00> (ø)
src/HelloClient.php 50.00% <ø> (ø) 25.00 <0.00> (ø)
src/Lib/PKCE.php 100.00% <ø> (ø) 6.00 <0.00> (ø)
src/Type/AuthCookie.php 100.00% <100.00%> (ø) 8.00 <8.00> (ø)
src/Type/Claims.php 100.00% <100.00%> (ø) 1.00 <1.00> (ø)
src/Type/OIDC.php 88.88% <100.00%> (ø) 7.00 <7.00> (ø)
src/Type/AuthUpdates.php 0.00% <0.00%> (ø) 10.00 <10.00> (ø)

Fix logout callback issue: Corrected callback from `getLoginSync` to `getLogoutSync` and updated unit test.
* fix: resolve PHPCS coding standards violations in src folder.

* fixed coding standard

* Added --exclude=Generic.Files.LineLength to composer configuration

* Fix deprecation in PHP 8.4: Explicitly mark parameters as nullables.
@fraggerfox fraggerfox force-pushed the fix-gha-workflow branch 2 times, most recently from 7d7efa7 to daede61 Compare December 18, 2024 19:46
@fraggerfox fraggerfox marked this pull request as ready for review December 19, 2024 11:09
@UnnikrishnanBhargavakurup UnnikrishnanBhargavakurup merged commit a9e6f63 into master Dec 19, 2024
4 of 7 checks passed
@fraggerfox fraggerfox deleted the fix-gha-workflow branch December 19, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants