Skip to content

Conversation

@fraggerfox
Copy link
Collaborator

@fraggerfox fraggerfox commented Dec 23, 2024

This pull request includes several updates to type annotations, PHP version, and test improvements. The changes primarily focus on enhancing type safety, updating dependencies, and improving the clarity and robustness of tests.

Type Annotation Updates:

  • Updated various type annotations in src/Exception/CallbackException.php to allow mixed types in errorDetails and related methods. [1] [2]
  • Changed type hints in src/HelloRequest/HelloRequest.php and src/HelloRequest/HelloRequestInterface.php to allow mixed types for fetched parameters and headers. [1] [2]

Dependency Updates:

  • Updated the PHP version to 8.3 in the .github/workflows/php-tests.yml file.
  • Modified the psalm command in composer.json to disable caching.

Test Improvements:

  • Added type annotations to various test methods to ensure they return void in multiple test files. [1] [2] [3]
  • Enhanced assertions in tests/Handler/AuthTest.php to include type checks for fetched values.

These changes collectively improve the codebase's type safety, ensure compatibility with the latest PHP version, and enhance test reliability.

@fraggerfox fraggerfox self-assigned this Dec 23, 2024
@codecov
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/Handler/Login.php 50.00% 2 Missing ⚠️
src/Type/AuthUpdates.php 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ Complexity Δ
src/Exception/CallbackException.php 100.00% <ø> (ø) 2.00 <0.00> (ø)
src/Handler/Callback.php 68.55% <ø> (ø) 35.00 <0.00> (ø)
src/Handler/Logout.php 100.00% <ø> (ø) 4.00 <0.00> (ø)
src/HelloClient.php 51.85% <100.00%> (+1.85%) 25.00 <0.00> (ø)
src/HelloRequest/HelloRequest.php 82.75% <100.00%> (ø) 13.00 <4.00> (ø)
src/Utils/QueryParamFetcher.php 100.00% <ø> (ø) 2.00 <0.00> (ø)
src/Handler/Login.php 95.23% <50.00%> (-1.49%) 11.00 <0.00> (ø)
src/Type/AuthUpdates.php 0.00% <0.00%> (ø) 11.00 <2.00> (ø)

@fraggerfox fraggerfox marked this pull request as ready for review December 24, 2024 08:12
@UnnikrishnanBhargavakurup UnnikrishnanBhargavakurup merged commit 2a058c0 into master Dec 24, 2024
6 of 7 checks passed
@UnnikrishnanBhargavakurup UnnikrishnanBhargavakurup deleted the fix-test-lint-issues branch December 24, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants