Skip to content

Conversation

@fraggerfox
Copy link
Collaborator

Fix more lint issues with phpstan.

@fraggerfox fraggerfox self-assigned this Dec 23, 2024
@codecov
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/Handler/Auth.php 50.00% 1 Missing ⚠️
src/HelloClient.php 0.00% 1 Missing ⚠️
src/Lib/TokenFetcher.php 66.66% 1 Missing ⚠️
Files with missing lines Coverage Δ Complexity Δ
src/Config/HelloConfig.php 100.00% <100.00%> (ø) 22.00 <1.00> (ø)
src/Config/HelloConfigBuilder.php 100.00% <100.00%> (ø) 22.00 <1.00> (ø)
src/Exception/CallbackException.php 100.00% <ø> (ø) 2.00 <0.00> (ø)
src/Handler/Callback.php 68.55% <100.00%> (+1.68%) 35.00 <26.00> (-3.00) ⬆️
src/Handler/Login.php 96.72% <100.00%> (ø) 11.00 <8.00> (-1.00)
src/HelloRequest/HelloRequest.php 82.75% <100.00%> (ø) 13.00 <4.00> (ø)
src/Lib/AuthHelper.php 98.03% <ø> (ø) 17.00 <0.00> (ø)
src/Lib/Crypto.php 97.43% <ø> (ø) 15.00 <0.00> (ø)
src/Type/OIDC.php 88.88% <ø> (ø) 7.00 <0.00> (ø)
src/Handler/Auth.php 60.00% <50.00%> (ø) 6.00 <3.00> (ø)
... and 2 more

@fraggerfox fraggerfox changed the title Fix more lint issues. Fix more src lint issues. Dec 23, 2024
@fraggerfox fraggerfox marked this pull request as ready for review December 23, 2024 18:49
@UnnikrishnanBhargavakurup UnnikrishnanBhargavakurup merged commit 7b02935 into master Dec 23, 2024
5 of 7 checks passed
@UnnikrishnanBhargavakurup UnnikrishnanBhargavakurup deleted the fix-more-lint-issues branch December 23, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants