Fix lint issues in Config. #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fraggerfox
force-pushed
the
fix-lint-issues
branch
from
bfb32b9 to
8c946b0
Compare
fraggerfox
force-pushed
the
fix-lint-issues
branch
from
559062f to
44177f3
Compare
fraggerfox
force-pushed
the
fix-lint-issues
branch
from
44177f3 to
84e21f1
Compare
UnnikrishnanBhargavakurup
previously approved these changes
Dec 20, 2024
UnnikrishnanBhargavakurup
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve type annotations, add missing dependencies, and enhance error handling. The most important changes include updating
composer.jsonto add required extensions and packages, adding type annotations across multiple files, and refining error handling in theCallbackclass.Dependencies and requirements:
composer.json: Addedext-json,ext-openssl, andext-curlas required extensions, and addedfriendsofphp/php-cs-fixerto the dev dependencies. [1] [2]Type annotations:
src/Config/ConfigInterface.php: Added return type annotations for multiple methods.src/Config/Constants.php: Added type annotations for several static properties and methods. [1] [2] [3]src/Config/HelloConfig.php: Added type annotations for multiple properties and methods. [1] [2]src/Config/HelloConfigBuilder.php: Added type annotations for multiple properties and methods. [1] [2] [3] [4]Error handling:
src/Handler/Callback.php: Improved error handling by adding type annotations and refining the error handling logic in thehandleCallbackmethod. [1] [2] [3] [4] [5] [6] [7]Other minor improvements:
src/Exception/CallbackException.php,src/Exception/CryptoFailedException.php,src/Exception/DecryptionFailedException.php,src/Exception/InvalidSecretException.php,src/Exception/NotImplementedException.php, andsrc/Exception/SameSiteCallbackException.php. [1] [2] [3] [4] [5] [6] [7]src/Handler/Auth.phpandsrc/Handler/Invite.php. [1] [2] [3] [4] [5]