fix(hashalgo): Use same aliases as Ort Kotlin upstream#14
Merged
heliocastro merged 1 commit intoheliocastro:mainfrom Nov 10, 2025
Merged
fix(hashalgo): Use same aliases as Ort Kotlin upstream#14heliocastro merged 1 commit intoheliocastro:mainfrom
heliocastro merged 1 commit intoheliocastro:mainfrom
Conversation
Signed-off-by: Helio Chissini de Castro <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the version to 0.4.1 and refactors the HashAlgorithm class from a simple Enum to a Pydantic BaseModel, enabling more flexible validation and string-based initialization. It also fixes a typo in test data and standardizes quote usage.
- Refactored
HashAlgorithmfrom Enum to Pydantic BaseModel with aliases, empty values, and validation support - Added class methods
from_string()andcreate()for flexible algorithm detection - Fixed typo "Giot" → "Git" in test data and updated hash examples
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| uv.lock | Updated version from 0.4.0 to 0.4.1 |
| pyproject.toml | Updated version from 0.4.0 to 0.4.1 |
| src/ort/models/hash_algorithm.py | Refactored from Enum to Pydantic BaseModel with validation and class methods |
| tests/data/example_simple_curation.yml | Standardized quotes and updated hash examples; inconsistent algorithm naming |
| tests/data/example_curations.yml | Fixed typo 'Giot' to 'Git' |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.