Open
Conversation
Signed-off-by: Isaac Marovitz <isaacryu@icloud.com>
IsaacMarovitz
commented
Mar 6, 2025
|
|
||
| uint32_t absoluteSwitch[] = | ||
| { | ||
| uint32_t absoluteSwitch[] = { |
Contributor
Author
There was a problem hiding this comment.
Oversight in clang-format config llvm/llvm-project#90837
There was a problem hiding this comment.
Set BreakBeforeBraces to Allman, to match the original styling. It keeps all braces on the next line, even array initializers.
Contributor
Author
There was a problem hiding this comment.
This is already set, it doesn't affect array initialisers properly.
There was a problem hiding this comment.
Yes, this is an open issue with clang-format. There's no way to customize the line breaking behavior with array initializers. llvm/llvm-project#90837
There was a problem hiding this comment.
Oh, I see you already linked the Issue.
Signed-off-by: Isaac Marovitz <isaacryu@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.