Open
Conversation
f24767d to
68543c5
Compare
Devkit key is all zeros, unlike the all-precious retail key.
Thanks to @ran-j for pointing this out!
Member
|
Hmm, I couldn't get the devkit code to execute, is the check correct? Xenia seems to try two times and goes with whichever manages to succeed: https://github.com/xenia-project/xenia/blob/3d30b2eec3ab1f83140b09745bee881fb5d5dde2/src/xenia/cpu/xex_module.cc#L938 Maybe to validate that the decryption succeeded, it could try to validate the PE header, but I don't know if that's something that'd work consistently across games. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using my limited knowledge to fix smaller issues. 💪🏻
Fixes
Additional Notes
I made a few changes as suggested by the IDE
inlineis implied bytemplateelseis redundant afterreturnreturn value;is unreachable afterassert(false && ...)