Skip to content

Make advertise logo overlay aspect ratio aware #1727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DeaTh-G wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −0
Open

Make advertise logo overlay aspect ratio aware #1727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions UnleashedRecomp/patches/aspect_ratio_patches.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1686,3 +1686,13 @@ void EndingTextPositionMidAsmHook(PPCRegister& r31, PPCRegister& f13)
else if (align == ALIGN_LEFT)
f13.f64 += 133.0 * (1.0 - g_aspectRatioNarrowScale);
}

// Offsets calculated by converting the 4:3 values to 16:9 space and then substracting the differences from the original 16:9 position.
// Afterward fact checked by overlaying a capture from the original hardware at 4:3 and a capture from recomp at 4:3.
void AdvertiseLogoPlacementMidAsmHook(PPCRegister& f0, PPCRegister& f13, PPCRegister& f12, PPCRegister& f11)
{
f0.f64 += -133.0f / 1280.0f * (1.0 - g_aspectRatioNarrowScale);
f13.f64 += 3.5f / 720.0f * (1.0 - g_aspectRatioNarrowScale);
f12.f64 += -133.0f / 1280.0f * (1.0 - g_aspectRatioNarrowScale);
f11.f64 += 3.5f / 720.0f * (1.0 - g_aspectRatioNarrowScale);
}
5 changes: 5 additions & 0 deletions UnleashedRecompLib/config/SWA.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1153,3 +1153,8 @@ registers = ["f1"]
name = "CEvilSonicContext_CStateWall_LeaveRotationMidAsmHook"
address = 0x82406774
registers = ["f1"]

[[midasm_hook]]
name = "AdvertiseLogoPlacementMidAsmHook"
address = 0x82B729A0
registers = ["f0", "f13", "f12", "f11"]
Loading