change value of hdate.Tamuz to Tammuz#3
Merged
Conversation
In my expeirience, this spelling is more common Better reflects the original langauge, in which the mem is geminated Brings consistancy with hebcal-go, where the Fast of Tummuz has 2 M's Tammuz is now spelled the same, wether it a fast, rosh chodes, or just any other day Brings consistancy with Iyyar, which already reflects the geminated yud Brings greater consistancy to overall spelling conventions used
mjradwin
approved these changes
Jul 20, 2025
mjradwin
added a commit
to hebcal/hebcal-go
that referenced
this pull request
Jul 27, 2025
see hebcal/hdate#3 for more details
mjradwin
added a commit
to hebcal/hdate-js
that referenced
this pull request
Dec 19, 2025
mjradwin
added a commit
to hebcal/hebcal-es6
that referenced
this pull request
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my expeirience, this spelling is more common
Better reflects the original langauge, in which the mem is geminated Brings consistancy with hebcal-go, where the Fast of Tummuz has 2 M's Tammuz is now spelled the same, wether it a fast, rosh chodes, or just any other day Brings consistancy with Iyyar, which already reflects the geminated yud Brings greater consistancy to overall spelling conventions used