Set flash message immediately when turbo stream format#251
Open
joelzwarrington wants to merge 1 commit intoheartcombo:mainfrom
Open
Set flash message immediately when turbo stream format#251joelzwarrington wants to merge 1 commit intoheartcombo:mainfrom
joelzwarrington wants to merge 1 commit intoheartcombo:mainfrom
Conversation
Author
|
Hi @carlosantoniodasilva 👋 would you mind having a look at this? 🙇 |
Member
carlosantoniodasilva
left a comment
There was a problem hiding this comment.
@joelzwarrington thanks for the PR.
I'm looking into this, and also working on a test, but it looks like there's more to Turbo we need to handle to work with it correctly out of the box: #230.
It might take a bit to get it sorted out, but I want to get it working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When responding to a turbo_stream format, the flash should be displayed immediately as turbo streams are rendered in the same request.
When not displaying the flash message immediately, one would see the flash on a subsequent request.
When implementing the turbo stream, a developer would still need to render the flash themselves using something like this (or some partial):