flux: generic controller support#858
Merged
illume merged 1 commit intoJun 29, 2026
Merged
Conversation
811d37b to
27fc149
Compare
59e06e6 to
43bc88c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Flux plugin’s “Controllers” health and display logic to support third-party Flux-adjacent controllers by switching the Controllers data source from Pods to Deployments, and by using a generic controller/watcher name filter. It also aims to prevent unintended all-namespace queries on non-bootstrapped clusters.
Changes:
- Switched Controllers discovery from Pod listing to Deployment listing and filtered deployments by name containing
controller/watcher. - Updated health/readiness logic and UI to use deployment replica readiness instead of pod phase.
- Updated Controllers table to link to Deployment details and to display ready replica counts and the container image from the deployment template.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Please check the git commit message follows the format... something like:
|
d40c9d8 to
beb0b62
Compare
Signed-off-by: Chris Schindlbeck <chris.schindlbeck@gmail.com>
beb0b62 to
acbc3ea
Compare
Contributor
Author
|
@illume tested in the cluster, works. also changed commit message and implemented ghcp suggestions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Controllers section in Flux Checks was built on a hardcoded allowlist of pod label selectors covering only the six standard Flux controllers plus source-watcher. Any third-party controller deployed alongside Flux — such as terraform-runner-tofu-controller (Tofu/OpenTofu) — was silently omitted.
Additionally, the pod list was scoped to fluxCheck.namespace, which defaults to an empty string on non-bootstrapped clusters, causing Headlamp to fall back to listing pods across all namespaces.
Changes