radius: implement i18n#844
Open
vtushar06 wants to merge 2 commits into
Open
Conversation
The radius plugin had no internationalization, so its UI strings were hardcoded English. This wraps the user-facing strings in the list and detail views with t(), the same setup the other plugins use, and adds the generated English locale. Sidebar entry labels are left as is (same as karpenter) since they are registered outside of React. Provisioning status values come from the API as data, so they are not translated. tsc, lint and build all pass. Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>
Author
Contributor
There was a problem hiding this comment.
Pull request overview
This PR brings the radius plugin in line with other large Headlamp plugins by introducing i18n support: it wraps user-facing UI strings with t() and adds the plugin’s English locale plus the headlamp.i18n package configuration.
Changes:
- Added
useTranslation()and wrapped UI strings witht()across overview, list, and detail views (applications, environments, resources, resource types). - Updated dynamic/count-based labels to use i18n interpolation/plural forms (e.g.,
{{count}}). - Added
headlamp.i18nconfig toradius/package.jsonand generatedradius/locales/en/translation.json.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| radius/src/resources/ResourceDetailView.tsx | Localized resource detail view labels, sections, and empty/error states. |
| radius/src/resources/index.tsx | Localized resources list title and table column headers. |
| radius/src/resource-types/ResourceTypeDetailView.tsx | Localized resource type detail view (tabs, headings, table labels, empty states). |
| radius/src/resource-types/index.tsx | Localized resource types list title, description, and table headers. |
| radius/src/radius-overview/index.tsx | Localized overview dashboard sections and status count labels. |
| radius/src/index.tsx | Localized plugin settings field label/help text. |
| radius/src/environments/index.tsx | Localized environments list title and table headers. |
| radius/src/environments/EnvironmentDetailView.tsx | Localized environment detail view tabs/sections/table headers and empty/error states. |
| radius/src/applications/index.tsx | Localized applications list title and table headers. |
| radius/src/applications/ApplicationDetailView.tsx | Localized application detail view sections/table labels and empty/error states. |
| radius/package.json | Added headlamp.i18n configuration for English locale generation/loading. |
| radius/locales/en/translation.json | Added generated English translation catalog for all introduced keys. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Drop toLowerCase on the translated title in the empty-state message, since lowercasing a translated string is not locale-safe (Turkish casing, etc). Also run prettier on EnvironmentDetailView.tsx to fix the format check. Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>
Author
illume
requested changes
Jun 24, 2026
illume
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution.
Could you take a look at the commit messages in this PR? We follow a Linux kernel style for git commits — see the contributing guide and git log for examples.
Commits that need attention
radius: implement i18n— Description must start with a capital letter — e.g.frontend: HomeButton: Fix the buttonnotfrontend: HomeButton: fix the button.radius: address review feedback and fix formatting— Description must start with a capital letter — e.g.frontend: HomeButton: Fix the buttonnotfrontend: HomeButton: fix the button.
Commit guidelines
- Use atomic commits focused on a single change.
- Use the title format
<area>: <Description of changes>— description must start with a capital letter. - Keep the title under 72 characters (soft requirement).
- Explain the intention and why the change is needed.
- Make commit titles meaningful and describe what changed.
- Do not add code that a later commit rewrites; squash or reorder commits instead.
- Do not include
Fixes #NNin commit messages.
Good examples:
frontend: HomeButton: Fix so it navigates to homebackend: config: Add enable-dynamic-clusters flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The radius plugin was the only one of its size with no i18n. This continues the plugin i18n rollout (KEDA, karpenter, flux) by wrapping radius's user-facing strings with t() and generating the English locale with headlamp-plugin i18n.
What changed:
Left out on purpose: sidebar entry labels (registered outside React, same as karpenter) and raw provisioning status values that come straight from the API.
tsc, lint and build pass locally.
Fixes #843