flux: Fix table malformatting when toggling Show/Hide columns#810
Open
AshutoshSharma-pixel wants to merge 1 commit into
Open
flux: Fix table malformatting when toggling Show/Hide columns#810AshutoshSharma-pixel wants to merge 1 commit into
AshutoshSharma-pixel wants to merge 1 commit into
Conversation
Signed-off-by: Ashutosh Sharma <itsashutosh769@gmail.com>
AshutoshSharma-pixel
force-pushed
the
fix/flux-table-column-toggle
branch
from
3c73045 to
9d43701
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #77
The Show/Hide columns feature caused table malformatting because columns using accessorFn without an explicit id could not be uniquely identified by TanStack Table when toggled, causing layout corruption.
Fix: Updated processedColumns in flux/src/common/Table.tsx to dynamically generate a unique id for any column that doesn't explicitly have one or lacks an accessorKey. This covers all Flux plugin list/table views automatically.
All checks passing: tsc, lint, format.