Skip to content
This repository was archived by the owner on May 11, 2026. It is now read-only.
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/instrumentation/jvmagent.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ will override the environment variables. The property names are:
| HAWKULAR_APM_USERNAME | The username to use with the REST client when communicating with the APM server. The default defined in the _setenv.sh_ script is *_jdoe_*.
| HAWKULAR_APM_PASSWORD | The password to use with the REST client when communicating with the APM server. The default defined in the _setenv.sh_ script is *_password_*.
| HAWKULAR_APM_CONFIG_REFRESH | Optional business transaction configuration refresh interval (in seconds).
| HAWKULAR_APM_LOG_LEVEL | The logging level to use when reporting client collector information to the console (uses Java Util Logging levels. The default is _INFO_.
| HAWKULAR_APM_LOG_LEVEL | The logging level to use when reporting client collector information to the console (uses Java Util Logging levels. The default is _INFO_. Allowed values are FINEST, FINER, FINE, INFO, WARNING and SEVERE.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

minor comment: maybe use the same styling? In the previous sentence it is in italics..

Just for curiosity. Did you looked/used setenv.sh ? There is a a partial list of all values

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 - if you could change to italics that would be great. Otherwise LGTM.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we should standardize the formatting for the entire table while we're at it. The parameters and variables are formatted differently in every row.

Could we make all the parameters and variables in the table bold monospace?

| HAWKULAR_APM_SERVICE_NAME | The service name to be added to the trace information. When not set, the environment variables `OPENSHIFT_BUILD_NAMESPACE` and `OPENSHIFT_BUILD_NAME` are used to derive a sensible value.
|===

Expand Down