Skip to content

🧹 [Code Health] Replace NSAppleScript with native AXUIElement in getDockRects#32

Open
hatimhtm wants to merge 1 commit intomainfrom
chore/refactor-getdockrects-native-8338405162073594645
Open

🧹 [Code Health] Replace NSAppleScript with native AXUIElement in getDockRects#32
hatimhtm wants to merge 1 commit intomainfrom
chore/refactor-getdockrects-native-8338405162073594645

Conversation

@hatimhtm
Copy link
Copy Markdown
Owner

🎯 What: The getDockRects() method in Click2Minimize/AppDelegate.swift has been refactored to use native macOS APIs (AXUIElement and NSRunningApplication) instead of relying on NSAppleScript.

💡 Why: NSAppleScript is slow to compile and execute, especially when called repeatedly to query Dock item layouts. By using the native Accessibility APIs directly, we avoid the overhead of AppleScript compilation, inter-process communication overhead with "System Events", and significantly improve the performance and maintainability of the codebase.

Verification:

  1. Replaced the NSAppleScript implementation using a Python manipulation script to ensure precise replacement without introducing typos.
  2. Verified the file structurally via cat Click2Minimize/AppDelegate.swift.
  3. Ran ./test_build_dmg.sh to ensure the Swift files remain syntactically sound in the mocked CI build environment. All tests passed.
  4. Cleaned up all temporary Python scripts used for manipulation and restored dist/Click2Minimize.dmg so that the commit is clean.

Result: A much cleaner, robust, and performant approach to querying Dock items without relying on slow AppleScript execution.


PR created automatically by Jules for task 8338405162073594645 started by @hatimhtm

…ockRects

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant