-
Notifications
You must be signed in to change notification settings - Fork 0
ETT-314 Remove apparently-unused template field from ht_institutions #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Regenerate mysqldump of `ht_institutions` without `template` column. - This is the full dump, I believe the previous iteration was hand-crafted (with some columns excluded). - Prefer to use data that can be regenerated with a minimum of fuss, hoping to help mitigate schema drift.
Comment `collection_names`
|
@moseshll Some of the data from ht_institutions makes me a little bit itchy -- maybe especially the list of IdPs for institutions that aren't enabled (these may be former members, members in testing, etc) -- certainly the IdPs for enabled ones is available via the wayf and the public institutions dump anyway so that stuff is fine. Likewise the specific scopes we allow per IdP I'm not sure about - again, I think this is probably OK at least for "enabled" |
|
@aelkiss it's actually fine to have some custom "dump schemas" for lack of a better term. I'll restore the file with something more like the existing dump, and keep the code that creates it around for posterity next time we want to recreate the data. Would it be too involved to close/delete this PR and erase the branch from history? |
|
I think if we close the PR and delete the branch GitHub with garbage collect it. I don't think it's a major issue. |
|
@moseshll Do we still want to close this PR and delete the branch? |
|
@aelkiss Closing and deleting. I have notes on what should be done as a follow-up. |
ht_proxiesht_logs,ht_contacts, andht_contact_typeswhich now have anotis_prefixht_institutions.templateht_institutionswithouttemplatecolumn.