ETT-1233 Catalog should keep Advanced Search "adv=1" in URL when a fa… #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cet is added or removed - Modify `SearchStructure` class to extract an instance variable `adv` from the query, to be used when crafting "remove filter" URLs - Modify `Search/Home.php` to behave similarly when crafting the "add filter" URLs. - Add a simple-minded Playwright test to simulate adding and removing a facet on a search URL with the `adv` set to 1.
aelkiss
requested changes
Jan 9, 2026
Member
aelkiss
left a comment
aelkiss
left a comment
There was a problem hiding this comment.
The test looks good in terms of covering both cases below -- that we keep &adv=1 when adding a facet and when removing it.
Once we remove the extraneous debugging stuff this should be good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cet is added or removed
SearchStructureclass to extract an instance variableadvfrom the query, to be used when crafting "remove filter" URLsSearch/Home.phpto behave similarly when crafting the "add filter" URLs.advset to 1.