Skip to content

Fix caching of remote source tarballs - #11512

Merged
mergify[bot] merged 2 commits into
haskell:masterfrom
hasufell:issue-11511
Mar 4, 2026
Merged

Fix caching of remote source tarballs#11512
mergify[bot] merged 2 commits into
haskell:masterfrom
hasufell:issue-11511

Conversation

@hasufell

Copy link
Copy Markdown
Member

Fixes #11511


Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@hasufell

hasufell commented Feb 24, 2026

Copy link
Copy Markdown
Member Author

I don't fully understand what was going on here, but it appears that running monitorFiles within rerunIfChanged seems to be problematic and breaks the "mtime of downloaded tarball" >= "monitor start time" condition, constantly re-triggering a download. I simply floated it out and the problem is gone.

I verified that it still re-downloads when I change the URL, which seems to be the primary use case.

I'm not sure how I would create a test for this.

@ffaf1

ffaf1 commented Feb 24, 2026

Copy link
Copy Markdown
Collaborator

Template B: This PR does not modify behaviour or interface

Apparently this does modify behaviour, does it not?

@hasufell

Copy link
Copy Markdown
Member Author

Template B: This PR does not modify behaviour or interface

Apparently this does modify behaviour, does it not?

Well, I guess. But not in a way that breaks user interfaces.

@hasufell

Copy link
Copy Markdown
Member Author

Here's proof that the test captures the failure: https://github.com/haskell/cabal/actions/runs/22380895412?pr=11512

@hasufell

hasufell commented Mar 2, 2026

Copy link
Copy Markdown
Member Author

@ffaf1 is there anything else?

@ffaf1

ffaf1 commented Mar 2, 2026

Copy link
Copy Markdown
Collaborator

Nope, you can put the label!

@hasufell hasufell added the merge me Tell Mergify Bot to merge label Mar 2, 2026
@mergify mergify Bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days queued labels Mar 2, 2026
@mergify

mergify Bot commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

Rule: default


This pull request spent 2 hours 5 minutes 15 seconds in the queue, including 1 hour 54 minutes 49 seconds running CI.

Required conditions to merge
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Validate post job
    • check-neutral = Validate post job
    • check-skipped = Validate post job
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

mergify Bot added a commit that referenced this pull request Mar 4, 2026
@mergify
mergify Bot merged commit dd86008 into haskell:master Mar 4, 2026
248 of 250 checks passed
@mergify mergify Bot removed the queued label Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Caching downloaded remote source package tarballs is broken

4 participants