Make it compile with MicroHs #544
Conversation
|
Nice! Yes, please add CI. Have you gotten QuickCheck to compile yet? If so, it would be great to run the test suite (here and for |
Data/HashMap/Internal.hs
Outdated
|
|
||
| #if defined(__MHS__) | ||
| import Data.Traversable | ||
| #endif |
There was a problem hiding this comment.
This is okay, but also blecherous. We actually want to switch on the "base library" variant, not the compiler. Do you know if there's been any progress on how to do that?
There was a problem hiding this comment.
I don't know how to test for specific features in base.
In this case we could always import Data.Traversable; it's harmless for GHC. (It might need reordering of imports to avoid warnings. I'll check.)
There was a problem hiding this comment.
I think the condition is totally acceptable for this PR; I just think it would be good to open up a community discussion about the broader issue.
|
I'll update the PR. And I'll check if the testing works. |
|
MicroHs does not have unlifted types. But it supports the syntax, and you get the lifted types instead. Of course, that's not as efficient, but at least it allows more packages to build (e.g. async needs u-c) There's a new package for MicroHs called ghc-compat which implements parts of ghc specific modules. I will flesh it out as I need more things. |
| ) where | ||
|
|
||
| import Data.Traversable -- MicroHs needs this since its Prelude does not have Foldable&Traversable. | ||
| -- It's harmless for GHC, and putting it first avoid a warning. |
There was a problem hiding this comment.
| -- It's harmless for GHC, and putting it first avoid a warning. | |
| -- It's harmless for GHC, and putting it first avoids a warning. |
|
Would you please rebase? |
|
I'll rebase when I've added CI. |
3 participants
The title says it all.
I can add MicroHs CI if you want.